Skip to content

feat: add pagination and state options to list_sessions #1825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

me-her
Copy link

@me-her me-her commented Jul 7, 2025

  • Add ListSessionsConfig with max_sessions and include_state options
  • Improve performance by adding pagination and ordering by update_time
  • Fix state handling to only include session-specific state in list_sessions
  • Maintain backwards compatibility with existing API
  • Update all session service implementations

- Add ListSessionsConfig with max_sessions and include_state options
- Improve performance by adding pagination and ordering by update_time
- Fix state handling to only include session-specific state in list_sessions
- Maintain backwards compatibility with existing API
- Update all session service implementations
Copy link

google-cla bot commented Jul 7, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@me-her
Copy link
Author

me-her commented Jul 7, 2025

I wanted to have a "session title" addition to my sessions, tried to achieve it using state but then observed that the list sessions comes up with an empty state dictionary. also raised in #1340.

so, having an optional config to include state with list sessions is useful.

Also, if a user has 100+ sessions, we will still be sending all sessions, so added an optional field in config to limit the number of latest sessions returned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant